Skip to content

Conversation

@un-def
Copy link
Contributor

@un-def un-def commented May 20, 2024

  • document verbose option
  • fix and document version option
  • disable auto abbreviation

auto_abbrev was the reason -v (version option) didn't work as intended; it was treated as an abbreviated --verbose option. Since abbreviated options (e.g., --cmd-c, --install-dir-i) hadn't been documented, it's safe to disable this feature. However, --verbose-v abbreviation is so ubiquitous that it's worth allowing explicitly. For the same reason, --version is abbreviated to -V.

* document verbose option
* fix and document version option
* disable auto abbreviation
@mparada-suva
Copy link

Hi! I'm also interested in this PR and have a suggestion. Right now the verbose flag only affects the curl call in do_upload function. I believe it would be better if it would apply to all curl calls since the verbosity is most practical when debugging. I suggest the verbose flag to also affect other curl calls:

What do you think?

@zhuizhuhaomeng zhuizhuhaomeng merged commit 4ef7575 into openresty:master Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants